xiaoxiang781216 commented on code in PR #10911: URL: https://github.com/apache/nuttx/pull/10911#discussion_r1359764037
########## arch/arm/src/imxrt/imxrt_serial.c: ########## @@ -60,6 +60,24 @@ #ifdef USE_SERIALDRIVER +#if defined(SERIAL_HAVE_TXDMA) Review Comment: ```suggestion #if defined(SERIAL_HAVE_TXDMA) && CONFIG_IMXRT_EDMA_NTCD < 2 # error Each LPUART using TXDMA requires 2 EDMA TCDs for setting up transfers #endif ``` ########## arch/arm/src/imxrt/imxrt_serial.c: ########## @@ -60,6 +60,24 @@ #ifdef USE_SERIALDRIVER +#if defined(SERIAL_HAVE_TXDMA) +#if CONFIG_IMXRT_EDMA_NTCD < 2 +#error Each LPUART using TXDMA requires 2 EDMA TCDs for setting up transfers +#endif +#endif /* SERIAL_HAVE_TXDMA */ + +#if defined(SERIAL_HAVE_RXDMA) +#if CONFIG_IMXRT_EDMA_NTCD < 1 +#error Each LPUART using RXDMA requires 1 EDMA TCD for setting up transfers +#endif +#endif /* SERIAL_HAVE_RXDMA */ + +#if defined(SERIAL_HAVE_TXDMA) && defined(SERIAL_HAVE_RXDMA) +#if CONFIG_IMXRT_EDMA_NTCD < 3 Review Comment: ditto ########## arch/arm/src/imxrt/imxrt_serial.c: ########## @@ -60,6 +60,24 @@ #ifdef USE_SERIALDRIVER +#if defined(SERIAL_HAVE_TXDMA) +#if CONFIG_IMXRT_EDMA_NTCD < 2 +#error Each LPUART using TXDMA requires 2 EDMA TCDs for setting up transfers +#endif +#endif /* SERIAL_HAVE_TXDMA */ + +#if defined(SERIAL_HAVE_RXDMA) +#if CONFIG_IMXRT_EDMA_NTCD < 1 +#error Each LPUART using RXDMA requires 1 EDMA TCD for setting up transfers Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
