danielappiagyei-bc commented on code in PR #10911: URL: https://github.com/apache/nuttx/pull/10911#discussion_r1360098848
########## arch/arm/src/imxrt/imxrt_serial.c: ########## @@ -60,6 +60,24 @@ #ifdef USE_SERIALDRIVER +#if defined(SERIAL_HAVE_TXDMA) Review Comment: totally agree. I just found myself using a single lpuart device with DMA for the first time and it wasn't obvious to me why dma wasn't working properly (no transfers were occurring) until I stumbled upon the fact that you need to set `CONFIG_IMXRT_EDMA_NTCD` appropriately. I wasn't sure of a better way to communicate this to the user and was hoping these compile-time checks would help at least a few people :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
