davids5 commented on code in PR #10911:
URL: https://github.com/apache/nuttx/pull/10911#discussion_r1359839409
##########
arch/arm/src/imxrt/imxrt_serial.c:
##########
@@ -60,6 +60,24 @@
#ifdef USE_SERIALDRIVER
+#if defined(SERIAL_HAVE_TXDMA)
Review Comment:
the TCD pool is shared across all devices. So this is only a Band-Aid. For
the minimal case
##########
arch/arm/src/imxrt/imxrt_serial.c:
##########
@@ -1370,11 +1388,22 @@ static inline void imxrt_serialout(struct imxrt_uart_s
*priv,
****************************************************************************/
#ifdef SERIAL_HAVE_RXDMA
-static int imxrt_dma_nextrx(struct imxrt_uart_s *priv)
+static unsigned int imxrt_dma_nextrx(struct imxrt_uart_s *priv)
Review Comment:
:1
##########
arch/arm/src/imxrt/imxrt_serial.c:
##########
@@ -1531,12 +1560,13 @@ static int imxrt_dma_setup(struct uart_dev_s *dev)
modifyreg32(priv->uartbase + IMXRT_LPUART_BAUD_OFFSET,
0, LPUART_BAUD_RDMAE);
- /* Enable itnerrupt on Idel and erros */
+ /* Enable interrupt on Idle and errors */
Review Comment:
Add Over run to Comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
