xiaoxiang781216 commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382565207
########## fs/inode/fs_files.c: ########## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: can we call kmm_xxx without critical section, and hold the critical section when updating fl_files since fl_files extension is an infrequent operation, we can free the alloced memory if other thread happen to extend fl_files successfully at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
