raiden00pl commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1383242119
########## fs/inode/fs_files.c: ########## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: Thanks, I get it now. But in that case I'll leave this PR as it is. It fixes a bug I'm familiar with and is's just simple. We use fl_lock and critical section here but at least I know it works. Bigger change without serious testing have a high potential to break something and the possible bug can be difficult to detect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
