raiden00pl commented on code in PR #11125: URL: https://github.com/apache/nuttx/pull/11125#discussion_r1382943217
########## fs/inode/fs_files.c: ########## @@ -583,6 +605,7 @@ int fs_getfilep(int fd, FAR struct file **filep) ret = nxmutex_lock(&list->fl_lock); Review Comment: I still don't get why not call kmm_xx in critical section. I found 2 places in the kernel where we can find a similar practice - https://github.com/apache/nuttx/blob/d1c73b6ed65cfb51dc8b8a8a8dc5854e77638f55/sched/task/task_setup.c#L143 - https://github.com/apache/nuttx/blob/d1c73b6ed65cfb51dc8b8a8a8dc5854e77638f55/sched/mqueue/msgget.c#L72 I guess these code work fine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
