Xuanwo commented on code in PR #2881: URL: https://github.com/apache/incubator-opendal/pull/2881#discussion_r1299330758
########## bindings/ocaml/lib/opendal.ml: ########## @@ -18,5 +18,6 @@ *) module Operator = Operator +module Seek_from = Opendal_core.Seek_from Review Comment: Hi, does ocaml have native `Reader`, `IO` or `SeekFrom` concepts? How will ocaml's std lib handles File? On the other side, if a lib want to do read on a file, how will they call it? ########## bindings/ocaml/lib/operator.ml: ########## @@ -18,12 +18,30 @@ *) let new_operator = Opendal_core.Operator.operator +let stat = Opendal_core.Operator.stat let is_exist = Opendal_core.Operator.blocking_is_exist let create_dir = Opendal_core.Operator.blocking_create_dir let read = Opendal_core.Operator.blocking_read +let reader = Opendal_core.Operator.blocking_reader Review Comment: Since it could be a very long time before we add async support for ocaml binding. How about removing all `blocking_` prefix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
