Ranxy commented on code in PR #2881: URL: https://github.com/apache/incubator-opendal/pull/2881#discussion_r1299348025
########## bindings/ocaml/lib/opendal.ml: ########## @@ -18,5 +18,6 @@ *) module Operator = Operator +module Seek_from = Opendal_core.Seek_from Review Comment: the OCaml seek API looks like `val lseek : file_descr -> (pos:int) -> seek_command -> int`, we can't use it directly because it is bound to fd. If we design the seek API to be similar to OCaml, it will be `operator -> int -> Unix.seek_command -> (int,string) result`. At the same time, we still need `seek_from `This middle layer handles the calls of rust and ocaml functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
