Xuanwo commented on code in PR #2881: URL: https://github.com/apache/incubator-opendal/pull/2881#discussion_r1299337929
########## bindings/ocaml/lib/operator.ml: ########## @@ -18,12 +18,30 @@ *) let new_operator = Opendal_core.Operator.operator +let stat = Opendal_core.Operator.stat let is_exist = Opendal_core.Operator.blocking_is_exist let create_dir = Opendal_core.Operator.blocking_create_dir let read = Opendal_core.Operator.blocking_read +let reader = Opendal_core.Operator.blocking_reader Review Comment: > Wouldn't it look weird if we kept the `blocking_` prefix only for these two special functions? Yes, it looks weird. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
