adriencaccia commented on code in PR #4993:
URL: https://github.com/apache/opendal/pull/4993#discussion_r1808981247
##########
core/Cargo.toml:
##########
@@ -380,6 +380,7 @@ probe = { version = "0.5.1", optional = true }
getrandom = { version = "0.2", features = ["js"] }
[dev-dependencies]
+codspeed-criterion-compat = { version = "2.6.0", features = ["async",
"async_tokio"] }
criterion = { version = "0.5", features = ["async", "async_tokio"] }
Review Comment:
You can rename the `criterion` package to `codpseed-criterion-compat` to
avoid having to change all the `use` in the bench files:
```suggestion
criterion = { package="codspeed-criterion-compat", version = "2.7.2",
features = ["async", "async_tokio"] }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
