Xuanwo commented on code in PR #4993:
URL: https://github.com/apache/opendal/pull/4993#discussion_r1809779984
##########
core/Cargo.toml:
##########
@@ -380,6 +380,7 @@ probe = { version = "0.5.1", optional = true }
getrandom = { version = "0.2", features = ["js"] }
[dev-dependencies]
+codspeed-criterion-compat = { version = "2.6.0", features = ["async",
"async_tokio"] }
Review Comment:
The point is that external services should not appear in our code, even if
it's just for benchmarking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
