adriencaccia commented on code in PR #4993:
URL: https://github.com/apache/opendal/pull/4993#discussion_r1810282509
##########
core/Cargo.toml:
##########
@@ -380,6 +380,7 @@ probe = { version = "0.5.1", optional = true }
getrandom = { version = "0.2", features = ["js"] }
[dev-dependencies]
+codspeed-criterion-compat = { version = "2.6.0", features = ["async",
"async_tokio"] }
Review Comment:
@dqhl76 @Xuanwo if using what I outlined in
https://github.com/apache/opendal/pull/4993#discussion_r1808981247, the changes
to the source code (the `.rs` files) can be removed from this PR, and the
workflow will work.
So the only modified code would be the `dev-dependencies` section of the
`core/Cargo.toml` and the corresponding changes in `core/Cargo.lock`.
At this moment, this is the minimum footprint the codspeed integration can
have on the source code of a repository.
For example, [this
commit](https://github.com/CodSpeedHQ/pingora/commit/37f83517885ec59ec942ab3b55bc65ed393fb1e8#diff-ece5f678dd051959c8f661189e0ace2a47c82bb119ad47c2882c3399ef35e8e5)
shows the minimal changes for the installation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
