adriencaccia commented on code in PR #4993: URL: https://github.com/apache/opendal/pull/4993#discussion_r1810872699
########## .github/workflows/test_benchmark.yml: ########## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Benchmark Test + +on: + push: + branches: + - main + pull_request: + branches: + - main + paths: + - "core/src/**" + - "core/benches/**" + - "!core/src/docs/**" + - ".github/workflows/test_benchmark.yml" + # `workflow_dispatch` is needed by codspeed for first time trigger + workflow_dispatch: + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }} + cancel-in-progress: true + +jobs: + benchmark: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: Setup Rust toolchain + uses: ./.github/actions/setup + - name: Setup codspeed + run: cargo install cargo-codspeed + - name: Setup Memory env + uses: ./.github/services/memory/memory + - name: Build the benchmark targets + run: cargo codspeed build --features tests + - name: Run the benchmarks + uses: CodSpeedHQ/action@v3 + with: + run: cargo codspeed run + token: ${{ secrets.CODSPEED_TOKEN }} Review Comment: @Xuanwo I had a new idea for not directly modifying files under `core`: Only modify the github action, and not directly modifying the source code. That way, the code would only be modified during the actual action run. ```suggestion - name: Install codpseed-criterion-compat run: cargo add --dev --rename criterion --features async,async_tokio [email protected] - name: Build the benchmark targets run: cargo codspeed build --features tests - name: Run the benchmarks uses: CodSpeedHQ/action@v3 with: run: cargo codspeed run token: ${{ secrets.CODSPEED_TOKEN }} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
