adriencaccia commented on code in PR #4993:
URL: https://github.com/apache/opendal/pull/4993#discussion_r1810737794
##########
core/Cargo.toml:
##########
@@ -380,6 +380,7 @@ probe = { version = "0.5.1", optional = true }
getrandom = { version = "0.2", features = ["js"] }
[dev-dependencies]
+codspeed-criterion-compat = { version = "2.6.0", features = ["async",
"async_tokio"] }
Review Comment:
Hey @Xuanwo, unfortunately, we need to replace the `criterion` with
`codspeed-criterion-compat` in order to make CodSpeed work, and the changes in
`codspeed-criterion-compat` are way too specific to get integrated into the
upstream `criterion`.
If you do not want to touch at the code of `core`, another solution would be
to create a new crate named `benchmark` for example, and have all benchmarks
defined there, without impacting the source code `core`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
