yuchanns commented on code in PR #6293:
URL: https://github.com/apache/opendal/pull/6293#discussion_r2153565682
##########
.github/workflows/test_behavior_binding_go.yml:
##########
@@ -28,37 +28,24 @@ on:
type: string
jobs:
- set-build:
- runs-on: ubuntu-latest
- outputs:
- build: ${{ steps.set-matrix-build.outputs.build }}
- steps:
- - uses: actions/checkout@v4
- - id: set-matrix-build
- name: Setup Matrix Build
- run: |
- MATRIX=$(yq -o=json -I=0 '[.build[] | select(.os == "${{ inputs.os
}}")]' .github/scripts/test_go_binding/matrix.yaml | sed 's/ //g')
- echo "Matrix:"
- echo "$MATRIX" | jq .
- echo "build=$MATRIX" >> $GITHUB_OUTPUT
-
test:
- needs: [set-build]
name: ${{ matrix.cases.service }} / ${{ matrix.cases.setup }}
runs-on: ${{ inputs.os }}
strategy:
fail-fast: false
matrix:
cases: ${{ fromJson(inputs.cases) }}
- build: ${{ fromJson(needs.set-build.outputs.build) }}
steps:
- uses: actions/checkout@v4
+ - uses: actions/checkout@v4
+ with:
+ path: "opendal"
Review Comment:
The makefile requires a workspace layout:
```
opendal
openda-go-service
```
So ideally we don't need:
```yaml
- uses: actions/checkout@v4
```
We only need:
```yaml
- uses: actions/checkout@v4
with:
path: "opendal"
```
However, The docker setup requires an absolute path under `.`
https://github.com/apache/opendal/blob/69b61c52838f4661f6028b79e0a41c9e295c80de/.github/actions/test_behavior_binding_go/action.yaml#L40
If we do not clone the repository to `.`, it fails to setup the docker
images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
