yuchanns commented on code in PR #6293: URL: https://github.com/apache/opendal/pull/6293#discussion_r2153559254
########## bindings/go/Makefile: ########## @@ -67,10 +61,13 @@ FINAL_LIB_FILE := $(GITHUB_WORKSPACE)/$(SERVICE_PKG)/libopendal_c.$(OS).$(ARCH). # Build C library only when source files change $(C_LIB_FILE): opendal/bindings/c/src/*.rs opendal/bindings/c/Cargo.toml Review Comment: Not usually. While in a CGO case, the developer needs to create C bindings, generate a Go artifact, and set up the workspace. Having a Makefile can simplify this process. I choose Makefile to ensure consistency between GitHub Actions and Local development to avoid things like https://github.com/apache/opendal/issues/6279 happen again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
