yuchanns commented on code in PR #6293:
URL: https://github.com/apache/opendal/pull/6293#discussion_r2153768990
##########
.github/workflows/test_behavior_binding_go.yml:
##########
@@ -28,37 +28,24 @@ on:
type: string
jobs:
- set-build:
- runs-on: ubuntu-latest
- outputs:
- build: ${{ steps.set-matrix-build.outputs.build }}
- steps:
- - uses: actions/checkout@v4
- - id: set-matrix-build
- name: Setup Matrix Build
- run: |
- MATRIX=$(yq -o=json -I=0 '[.build[] | select(.os == "${{ inputs.os
}}")]' .github/scripts/test_go_binding/matrix.yaml | sed 's/ //g')
- echo "Matrix:"
- echo "$MATRIX" | jq .
- echo "build=$MATRIX" >> $GITHUB_OUTPUT
-
test:
- needs: [set-build]
name: ${{ matrix.cases.service }} / ${{ matrix.cases.setup }}
runs-on: ${{ inputs.os }}
strategy:
fail-fast: false
matrix:
cases: ${{ fromJson(inputs.cases) }}
- build: ${{ fromJson(needs.set-build.outputs.build) }}
steps:
- uses: actions/checkout@v4
+ - uses: actions/checkout@v4
+ with:
+ path: "opendal"
Review Comment:
> what are differences load repos side by side or use nested other
repositories
From the perspective of GHA, there is no difference (Side-loading was
excatly what we do before this PR). However, in local development, nested
repositories can cause issues when committing changes, as you need to be
careful not to commit unwanted repositories.
I want to maintain a consistent workspace layout between GHA and local
development so that they share the same structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
