BurntSushi commented on code in PR #634:
URL: https://github.com/apache/opendal-reqsign/pull/634#discussion_r2369039974
##########
core/src/time.rs:
##########
@@ -105,21 +63,17 @@ pub fn format_rfc3339(t: DateTime) -> String {
/// - `2022-03-01T08:12:34+00:00`
/// - `2022-03-01T08:12:34.00+00:00`
pub fn parse_rfc3339(s: &str) -> crate::Result<DateTime> {
Review Comment:
There's a number of them:
```rust
assert!("2025-09-22T17Z".parse::<jiff::Timestamp>().is_ok());
assert!("2025-09-22T17:30Z".parse::<jiff::Timestamp>().is_ok());
assert!("2025-09-22T17:30:00-04".parse::<jiff::Timestamp>().is_ok());
assert!("20250922T173000-04".parse::<jiff::Timestamp>().is_ok());
```
Jiff uses [Temporal's ISO
8601](https://tc39.es/proposal-temporal/#sec-temporal-iso8601grammar) format.
It's a blend of RFC 3339, RFC 9557 and ISO 8601. You can read [more about it
here](https://docs.rs/jiff/latest/jiff/fmt/temporal/index.html).
In theory Jiff could provide a "strict RFC 3339" parser, but it's not clear
to me how useful that is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
