tisonkun commented on code in PR #634: URL: https://github.com/apache/opendal-reqsign/pull/634#discussion_r2377717284
########## core/src/time.rs: ########## @@ -18,68 +18,26 @@ //! Time related utils. use crate::Error; -use chrono::format::Fixed; -use chrono::format::Item; -use chrono::format::Numeric; -use chrono::format::Pad; -use chrono::SecondsFormat; -use chrono::Utc; +use std::str::FromStr; -/// DateTime is the alias for chrono::DateTime<Utc>. -pub type DateTime = chrono::DateTime<Utc>; +/// DateTime is the alias for `jiff::Timestamp`. +pub type DateTime = jiff::Timestamp; Review Comment: Yes. Per https://github.com/apache/opendal-reqsign/pull/634#discussion_r2370741703 I'll do the rename. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
