Xuanwo commented on code in PR #634: URL: https://github.com/apache/opendal-reqsign/pull/634#discussion_r2369049890
########## core/src/time.rs: ########## @@ -105,21 +63,17 @@ pub fn format_rfc3339(t: DateTime) -> String { /// - `2022-03-01T08:12:34+00:00` /// - `2022-03-01T08:12:34.00+00:00` pub fn parse_rfc3339(s: &str) -> crate::Result<DateTime> { Review Comment: Oh I see. I think the current behavior is fine, and I actually think it's better to let `parse_rfc3339` can accept more valid inputs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@opendal.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org