yangyang233333 opened a new pull request, #7820:
URL: https://github.com/apache/opendal/pull/7820
## Which issue does this PR close?
N/A — small doc-comment fix.
## Rationale
The doc comment on `S3Builder::disable_list_objects_v2` describes the
opposite of the actual behavior.
Current first line:
> Disable list objects v2 so that opendal will **not use** the older List
Objects V1 to list objects.
But setting `disable_list_objects_v2 = true` makes the backend select
`S3ListerV1` (see `backend.rs`, the `else if self.core.disable_list_objects_v2
{ ... S3ListerV1::new(...) }` branch). So disabling V2 makes OpenDAL **fall
back to** V1, not avoid it.
The wording also contradicts the very next sentence ("some legacy services
do not yet support V2"), which implies falling back to V1 is the intended
behavior.
This PR changes "will not use the older List Objects V1" → "will fall back
to the older List Objects V1" so the comment matches the code. No functional
change.
## Changes
- `core/services/s3/src/backend.rs`: one-line doc-comment wording fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
