Xuanwo commented on code in PR #7820:
URL: https://github.com/apache/opendal/pull/7820#discussion_r3472604654
##########
core/services/s3/src/backend.rs:
##########
@@ -404,7 +404,7 @@ impl S3Builder {
self
}
- /// Disable list objects v2 so that opendal will not use the older
+ /// Disable list objects v2 so that opendal will fall back to the older
Review Comment:
I think `enable_legacy_list_objects_v1` seems to be good but that introduce
a new config. I think it's find to implement as a follow-up.
##########
core/services/s3/src/backend.rs:
##########
@@ -404,7 +404,7 @@ impl S3Builder {
self
}
- /// Disable list objects v2 so that opendal will not use the older
+ /// Disable list objects v2 so that opendal will fall back to the older
Review Comment:
I feel `enable_legacy_list_objects_v1` seems to be good but that introduce a
new config. I think it's find to implement as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
