erickguan commented on code in PR #7820:
URL: https://github.com/apache/opendal/pull/7820#discussion_r3471396169
##########
core/services/s3/src/backend.rs:
##########
@@ -404,7 +404,7 @@ impl S3Builder {
self
}
- /// Disable list objects v2 so that opendal will not use the older
+ /// Disable list objects v2 so that opendal will fall back to the older
Review Comment:
```suggestion
/// Disable list objects v2 so that Openal will fall back to the older
```
I strongly suggest deprecating `disable_` functions and to use `enable`
instead because it takes time to understand some tricky combination of
configurations.
In this case, `enable_legacy_list_objects_v1` would do. It has been a while
since AWS deprecate this. Doc is
[here](https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjects.html).
> This action has been revised. We recommend that you use the newer version,
[ListObjectsV2](https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html),
when developing applications. For backward compatibility, Amazon S3 continues
to support ListObjects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
