ByteBaker commented on code in PR #7884:
URL: https://github.com/apache/opendal/pull/7884#discussion_r3545103638
##########
core/services/s3/src/backend.rs:
##########
@@ -721,10 +721,8 @@ impl S3Builder {
}
}
-impl Builder for S3Builder {
- type Config = S3Config;
-
- fn build(self) -> Result<impl Service> {
+impl S3Builder {
+ fn build_backend(self) -> Result<S3Backend> {
Review Comment:
I needed to test the constructor in a UT, but the construction was not
separate, it was happening inside `impl Builder`, which returned Service, not
`S3Backend`.
Doing this allowed me to test on `S3Backend` itself w/o duplicating much
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
