erickguan commented on code in PR #7884:
URL: https://github.com/apache/opendal/pull/7884#discussion_r3548445530
##########
core/services/s3/src/backend.rs:
##########
@@ -721,10 +721,8 @@ impl S3Builder {
}
}
-impl Builder for S3Builder {
- type Config = S3Config;
-
- fn build(self) -> Result<impl Service> {
+impl S3Builder {
+ fn build_backend(self) -> Result<S3Backend> {
Review Comment:
Good thought! Try build `S3Core` instead of building a `S3Backend`. An
arbitrary example:
```
fn new_test_core() -> CompfsCore {
CompfsCore {
info: ServiceInfo::new("compfs", "", ""),
capability: Capability::default(),
root: PathBuf::from("/data/root"),
dispatcher: Dispatcher::new().unwrap(),
buf_pool: oio::PooledBuf::new(16),
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
