erickguan commented on code in PR #7884:
URL: https://github.com/apache/opendal/pull/7884#discussion_r3552818016
##########
core/services/s3/src/core.rs:
##########
@@ -769,10 +768,24 @@ impl S3Core {
// Inject operation to the request.
.extension(Operation::Copy)
.extension(ServiceOperation("CopyObject"))
+ // AWS S3 doesn't care, but some other S3-compat providers
+ // require a mandatory `content-length` header to work
Review Comment:
```suggestion
// AWS S3 doesn't define `Content-Length` in CopyObject. S3
allows `Content-Length: 0` siliently.
// Some providers require a unspecific `Content-Length`. We
allow e.g.,:
// - `NetApp`
```
##########
core/services/s3/src/core.rs:
##########
@@ -769,10 +768,24 @@ impl S3Core {
// Inject operation to the request.
.extension(Operation::Copy)
.extension(ServiceOperation("CopyObject"))
+ // AWS S3 doesn't care, but some other S3-compat providers
+ // require a mandatory `content-length` header to work
Review Comment:
```suggestion
// AWS S3 doesn't define `Content-Length` in CopyObject. S3
allows `Content-Length: 0` silently.
// Some providers require a unspecific `Content-Length`. We
allow e.g.,:
// - `NetApp`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
