krickert commented on PR #1513:
URL: https://github.com/apache/opennlp/pull/1513#issuecomment-6560398338
Thanks for the update and for writing up the follow-up in the description.
I've carefully reviewed the annotation work, the Dash and White_Space links,
and the Extended_Pictographic test and all of them look good.
A couple more nits before I approve:
1. The test lists 7 of the 18 code points that left Extended_Pictographic.
Could you loop over all of them (`U+1F1AE`, `U+1F7DA`..`U+1F7DB`,
`U+1F7F1`..`U+1F7FF`)?
2. `confusables.txt` changes quite a bit in 18.0 (about 1,300 mappings
removed and 1,450 added, for example `Ç` no longer maps to `C` plus comma
below).
* Could you mention in the description that skeleton output changes?
* Would you a test that checks the mapping count, like the one we have
for `CaseFolding`?
I confirmed that each data file is the unmodified `18.0.0` file from
unicode.org.
Thanks for contributing! After you get these two done I'll approve and at
least one other maintainer will weigh in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
