xlb3055 commented on PR #1513: URL: https://github.com/apache/opennlp/pull/1513#issuecomment-6654649644
Thanks for the follow-up. The remaining comments are addressed in bec92fe, retaining one squashed commit and the maintainer's changes: 1. NOTICE / NOTICE.template / distr NOTICE / META-INF NOTICE restore Unicode License V3 for CLDR names and emoji-test classifications, and use "annotation table". 2. LANDMARK for U+1F6D9 is a documented project exception; upstream subgroup is transport-water (row notes + enum Javadoc). 3. ExtendedPictographicTest MethodSource covers all 18 dropped code points (U+1F1AE, U+1F7DA..U+1F7DB, U+1F7F1..U+1F7FF). WordSegmenterTest adds X ZWJ X for U+1F7F1: not one token (WB3c no longer applies; ZWJ still attaches to the first X via WB4 → [X+ZWJ, X]). 4. README: new enum constants are HAND, SKY_AND_WEATHER, and TOOL. Confusable example is OGONEK (U+02DB) no longer mapping to Latin i (verified). Ç is not used as the skeleton example because NFD still decomposes it. 5. ConfusablesTest locks mapping count at 6712 and asserts OGONEK no longer skeletons to i. The independent final local run passed 668 selected tests (211 API, 457 runtime), with no failures, errors or skips; Checkstyle and whitespace checks passed. A full offline build stopped on the uncached `zlibsvm-core:3.0.0` dependency, so I am not claiming a full-suite pass. The PR description includes the exact command and compatibility notes. Please re-review when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
