wgtmac commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1416694554
##########
parquet-column/src/main/java/org/apache/parquet/column/impl/ColumnWriterBase.java:
##########
@@ -409,4 +428,14 @@ abstract void writePage(
ValuesWriter definitionLevels,
ValuesWriter values)
throws IOException;
+
+ abstract void writePage(
+ int rowCount,
+ int valueCount,
+ Statistics<?> statistics,
+ SizeStatistics sizeStatistics,
Review Comment:
I agree. As they are also defined in the thrift file, I think it is not a
big problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
