emkornfield commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1416748595
##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/OffsetIndexBuilder.java:
##########
@@ -70,6 +72,14 @@ public long getFirstRowIndex(int pageIndex) {
public int getPageOrdinal(int pageIndex) {
return pageIndex;
}
+
+ @Override
+ public Optional<Long> getUnencodedByteArrayDataBytes(int pageIndex) {
+ if (unencodedByteArrayDataBytes == null ||
unencodedByteArrayDataBytes.length == 0) {
Review Comment:
i'm not sure the comparison to 0 here is correct? Can't a page be composed
of entirely empty strings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
