emkornfield commented on code in PR #1177:
URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1416747947


##########
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/OffsetIndex.java:
##########
@@ -64,4 +66,11 @@ public default long getLastRowIndex(int pageIndex, long 
rowGroupRowCount) {
     int nextPageIndex = pageIndex + 1;
     return (nextPageIndex >= getPageCount() ? rowGroupRowCount : 
getFirstRowIndex(nextPageIndex)) - 1;
   }
+
+  /**
+   * @param pageIndex
+   *          the index of the page
+   * @return unencoded/uncompressed size for BYTE_ARRAY types; or empty for 
other types.

Review Comment:
   It might be worth clarifying that even for BYTE_ARRAY types this value might 
not have been written?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to