mcvsubbu commented on a change in pull request #3942: Set processingException
when all queried segments cannot be acquired
URL: https://github.com/apache/incubator-pinot/pull/3942#discussion_r265635793
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
##########
@@ -196,6 +196,8 @@ public void onBecomeDroppedFromOffline(Message message,
NotificationContext cont
String tableNameWithType = message.getResourceName();
String segmentName = message.getPartitionName();
+ _instanceDataManager.deleteSegment(tableNameWithType, segmentName);
Review comment:
Also, can we not get the table data manager directly from here? Do we need
to go through the instanceDataManager? Dependency issues?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
