mcvsubbu commented on a change in pull request #3942: Set processingException
when all queried segments cannot be acquired
URL: https://github.com/apache/incubator-pinot/pull/3942#discussion_r267811436
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java
##########
@@ -110,6 +118,7 @@ public void shutDown() {
@Override
public void addSegment(@Nonnull ImmutableSegment immutableSegment) {
String segmentName = immutableSegment.getSegmentName();
+ untrackIfDeleted(segmentName);
Review comment:
This line should move down to be after line 128 (when we populate the
_segmentDataManagerMap). The segment is available for query only after that
point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
