mcvsubbu commented on a change in pull request #3942: Set processingException
when all queried segments cannot be acquired
URL: https://github.com/apache/incubator-pinot/pull/3942#discussion_r265634226
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
##########
@@ -151,6 +151,15 @@ public void removeSegment(@Nonnull String
tableNameWithType, @Nonnull String seg
}
}
+ @Override
+ public void deleteSegment(@Nonnull String tableNameWithType, @Nonnull String
segmentName) {
+ LOGGER.info("Tracking deleted segment: {} from table: {}", segmentName,
tableNameWithType);
Review comment:
I think we have other logs for dropping a segment, do we need this one as
well? If we really do, then it should go inside the 'if' statement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
