Jackie-Jiang commented on a change in pull request #4081: Support legacy time
type in SegmentValidationAndRetentionConfig
URL: https://github.com/apache/incubator-pinot/pull/4081#discussion_r272464714
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/SegmentsValidationAndRetentionConfig.java
##########
@@ -86,12 +88,17 @@ public void setTimeColumnName(String timeColumnName) {
this.timeColumnName = timeColumnName;
}
- public String getTimeType() {
- return timeType;
+ public TimeUnit getTimeType() {
+ return _timeType;
+ }
+
+ @JsonIgnore
+ public void setTimeType(TimeUnit timeType) {
Review comment:
Actually this is the cause of NPE... Removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
