Jackie-Jiang commented on a change in pull request #4081: Support legacy time
type in SegmentValidationAndRetentionConfig
URL: https://github.com/apache/incubator-pinot/pull/4081#discussion_r272693517
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/name/NormalizedDateSegmentNameGenerator.java
##########
@@ -44,11 +44,11 @@
private final SimpleDateFormat _inputSDF;
public NormalizedDateSegmentNameGenerator(String tableName, @Nullable String
segmentNamePrefix,
- @Nullable String excludeSequenceId, @Nullable String pushType, @Nullable
String pushFrequency,
- @Nullable String timeType, @Nullable String timeFormat) {
+ boolean excludeSequenceId, @Nullable String pushType, @Nullable String
pushFrequency, @Nullable TimeUnit timeType,
Review comment:
I don't believe so, it should only be called by the segment generator to
generate the segment name. Also, I don't want to spread legacy time type
support everywhere because that will make it hard to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
