Jackie-Jiang commented on a change in pull request #4081: Support legacy time type in SegmentValidationAndRetentionConfig URL: https://github.com/apache/incubator-pinot/pull/4081#discussion_r272692044
########## File path: pinot-common/src/main/java/org/apache/pinot/common/config/SegmentsValidationAndRetentionConfig.java ########## @@ -55,7 +57,7 @@ private String timeColumnName; @ConfigKey(value = "timeType") - private String timeType; + private TimeUnit _timeType; Review comment: Tested (we have this covered in TableConfigTest) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
