jackjlli commented on a change in pull request #4100: Refactor
HelixBrokerStarter to separate constructor and start()
URL: https://github.com/apache/incubator-pinot/pull/4100#discussion_r274090940
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartBrokerCommand.java
##########
@@ -107,23 +110,22 @@ public StartBrokerCommand setConfigFileName(String
configFileName) {
public boolean execute()
throws Exception {
try {
- Configuration configuration = readConfigFromFile(_configFileName);
- if (configuration == null) {
+ Configuration properties = readConfigFromFile(_configFileName);
Review comment:
Same as here and other places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
