jackjlli commented on a change in pull request #4100: Refactor
HelixBrokerStarter to separate constructor and start()
URL: https://github.com/apache/incubator-pinot/pull/4100#discussion_r276086705
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java
##########
@@ -161,110 +222,68 @@ public HelixBrokerStarter(@Nullable String brokerHost,
String helixClusterName,
CommonConstants.Broker.DEFAULT_BROKER_REFRESH_TIMEBOUNDARY_INFO_SLEEP_INTERVAL_MS));
_participantHelixManager.getMessagingService()
.registerMessageHandlerFactory(Message.MessageType.USER_DEFINE_MSG.toString(),
_tbiMessageHandler);
-
- addInstanceTagIfNeeded(helixClusterName, brokerId);
+ addInstanceTagIfNeeded();
+ brokerMetrics.addCallbackGauge("helix.connected", () ->
_participantHelixManager.isConnected() ? 1L : 0L);
Review comment:
This metric is quite often used. Can we put it to `CommonConstant`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
