jackjlli commented on a change in pull request #4100: Refactor
HelixBrokerStarter to separate constructor and start()
URL: https://github.com/apache/incubator-pinot/pull/4100#discussion_r274090687
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java
##########
@@ -96,33 +96,38 @@
protected TableConfig _offlineTableConfig;
protected TableConfig _realtimeTableConfig;
- protected void startBroker() {
+ protected void startBroker()
+ throws Exception {
startBrokers(1);
}
- protected void startBroker(int basePort, String zkStr) {
+ protected void startBroker(int basePort, String zkStr)
+ throws Exception {
startBrokers(1, basePort, zkStr);
}
- protected void startBrokers(int numBrokers) {
+ protected void startBrokers(int numBrokers)
+ throws Exception {
startBrokers(numBrokers, DEFAULT_BROKER_PORT, ZkStarter.DEFAULT_ZK_STR);
}
- protected void startBrokers(int numBrokers, int basePort, String zkStr) {
+ protected void startBrokers(int numBrokers, int basePort, String zkStr)
+ throws Exception {
_brokerBaseApiUrl = "http://localhost:"; + basePort;
for (int i = 0; i < numBrokers; i++) {
- Configuration configuration =
BrokerTestUtils.getDefaultBrokerConfiguration();
- configuration.setProperty("pinot.broker.timeoutMs", 100 * 1000L);
- configuration.setProperty("pinot.broker.client.queryPort",
Integer.toString(basePort + i));
- configuration.setProperty("pinot.broker.routing.table.builder.class",
"random");
-
configuration.setProperty(BrokerServerBuilder.DELAY_SHUTDOWN_TIME_MS_CONFIG, 0);
+ Configuration properties = new PropertiesConfiguration();
Review comment:
Can we rename it to `brokerConf`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
