npawar commented on a change in pull request #4193: Creation/deletion flow for
replica groups sets in realtime
URL: https://github.com/apache/incubator-pinot/pull/4193#discussion_r282305619
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/partition/ReplicaGroupPartitionAssignmentGenerator.java
##########
@@ -99,7 +103,11 @@ public ReplicaGroupPartitionAssignment
buildReplicaGroupPartitionAssignment(Stri
numColumnPartitions =
tableConfig.getIndexingConfig().getSegmentPartitionConfig().getNumPartitions(partitionColumn);
}
- int numReplicas = tableConfig.getValidationConfig().getReplicationNumber();
+
+ TableType tableType = tableConfig.getTableType();
+ int numReplicas =
Review comment:
Tried to pull the code into a common Utils.
Fixed such that this code will not be run in HLC case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
