npawar commented on a change in pull request #4193: Creation/deletion flow for
replica groups sets in realtime
URL: https://github.com/apache/incubator-pinot/pull/4193#discussion_r283936907
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/stream/StreamConfig.java
##########
@@ -101,15 +100,9 @@ public StreamConfig(Map<String, String> streamConfigMap) {
String consumerFactoryClassKey =
StreamConfigProperties.constructStreamProperty(_type,
StreamConfigProperties.STREAM_CONSUMER_FACTORY_CLASS);
- if (streamConfigMap.containsKey(consumerFactoryClassKey)) {
- _consumerFactoryClassName = streamConfigMap.get(consumerFactoryClassKey);
- } else {
- // For backward compatibility, default consumer factory is for Kafka.
- _consumerFactoryClassName = DEFAULT_CONSUMER_FACTORY_CLASS_NAME_STRING;
- }
- LOGGER
Review comment:
That log is too frequent - everytime a StreamConfig object is created. I'd
been meaning to remove it for a while
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
