npawar commented on a change in pull request #4193: Creation/deletion flow for
replica groups sets in realtime
URL: https://github.com/apache/incubator-pinot/pull/4193#discussion_r283935982
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/partition/ReplicaGroupPartitionAssignmentGenerator.java
##########
@@ -82,7 +86,7 @@ public void
writeReplicaGroupPartitionAssignment(ReplicaGroupPartitionAssignment
* @return Replica group partition assignment from the given configuration
*/
public ReplicaGroupPartitionAssignment
buildReplicaGroupPartitionAssignment(String tableNameWithType,
- TableConfig tableConfig, List<String> servers) {
+ TableConfig tableConfig, int numReplicas, List<String> servers) {
Review comment:
I couldn't move ReplicationUtils to pinot-common, because it needs to use
StreamConfig which is in pinot-core. This was the only way I could make it
work. Open to suggestions..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
