mcvsubbu commented on a change in pull request #4356: Emit metrics to track
performance against specific Service-Level-Objectives (SLO)
URL: https://github.com/apache/incubator-pinot/pull/4356#discussion_r296914580
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -361,6 +384,52 @@ private boolean forceLog(BrokerResponse brokerResponse,
long totalTimeMs) {
return false;
}
+
+ private void scoreResponse(BrokerResponse response, RequestStatistics stats)
{
+
+ try {
+
+ if (response == BrokerResponseNative.EMPTY_RESULT || response ==
BrokerResponseNative.NO_TABLE_RESULT
+ || response.getNumServersResponded() == 0 ||
!response.getProcessingExceptions().isEmpty()) {
+ // error response
+ _brokerMetrics.addMeteredTableValue(stats.getTableName(),
BrokerMeter.ERROR_RESPONSE, 1);
+ return;
+ }
+
+ if ((response.getNumServersQueried() > response.getNumServersResponded())
+ || stats.getFanoutType() == RequestStatistics.FanoutType.HYBRID
+ && response.getNumConsumingSegmentsQueried() <= 0 ||
response.isNumGroupsLimitReached()) {
Review comment:
is it worth noting here in a comment that it is possible that due to helix
timings, the externalview may contain (at least theoretically) no consuming
segments, and we will count that as a partial response even though the others
are in the process of getting created?
I am not sure if it is useful to add a log only for the case when we have
realtime tables but queries 0 consuming segments.
Lastly, does response.getNumConsumingSegmentsQueried() work correctly with
HLC?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
