mcvsubbu commented on a change in pull request #4356: Emit metrics to track
performance against specific Service-Level-Objectives (SLO)
URL: https://github.com/apache/incubator-pinot/pull/4356#discussion_r296912360
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -127,6 +131,15 @@ private String getDefaultBrokerId() {
public BrokerResponse handleRequest(JsonNode request, @Nullable
RequesterIdentity requesterIdentity,
RequestStatistics requestStatistics)
throws Exception {
+
+ BrokerResponse response = _handleRequest(request, requesterIdentity,
requestStatistics);
+ scoreResponse(response, requestStatistics);
+ return response;
+ }
+
+ private BrokerResponse _handleRequest(JsonNode request, @Nullable
RequesterIdentity requesterIdentity,
Review comment:
can u rename this to doHandleRequest() or handleRequestInternal()? thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
