mcvsubbu commented on a change in pull request #4356: Emit metrics to track
performance against specific Service-Level-Objectives (SLO)
URL: https://github.com/apache/incubator-pinot/pull/4356#discussion_r296918276
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -361,6 +384,52 @@ private boolean forceLog(BrokerResponse brokerResponse,
long totalTimeMs) {
return false;
}
+
+ private void scoreResponse(BrokerResponse response, RequestStatistics stats)
{
+
+ try {
+
+ if (response == BrokerResponseNative.EMPTY_RESULT || response ==
BrokerResponseNative.NO_TABLE_RESULT
+ || response.getNumServersResponded() == 0 ||
!response.getProcessingExceptions().isEmpty()) {
+ // error response
+ _brokerMetrics.addMeteredTableValue(stats.getTableName(),
BrokerMeter.ERROR_RESPONSE, 1);
+ return;
+ }
+
+ if ((response.getNumServersQueried() > response.getNumServersResponded())
+ || stats.getFanoutType() == RequestStatistics.FanoutType.HYBRID
+ && response.getNumConsumingSegmentsQueried() <= 0 ||
response.isNumGroupsLimitReached()) {
+ // partial response
+ _brokerMetrics.addMeteredTableValue(stats.getTableName(),
BrokerMeter.PARTIAL_RESPONSE, 1);
+ return;
+ }
+
+ TableConfig tableConfig = _tableConfigCache.get(stats.getTableName());
Review comment:
note: stats.getTableName() gets raw table name. Which table config are you
expecting to process below? I suppose realtime? I would imagine that freshness
(in general) will also apply to offline tables. We are not impleemnting that
now, I suppose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
