mayankshriv commented on a change in pull request #4387: Adding Calcite SQL
Parser and make another entry point to query Pinot
URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r300516190
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultipleOrEqualitiesToInClauseFilterQueryTreeOptimizer.java
##########
@@ -42,7 +43,7 @@ public FilterQueryTree optimize(FilterQueryOptimizerRequest
request) {
private FilterQueryTree optimize(FilterQueryTree filterQueryTree,
FilterQueryTree parent) {
if (filterQueryTree.getOperator() == FilterOperator.OR) {
- Map<String, Set<String>> columnToValues = new HashMap<>();
+ Map<String, Set<String>> columnToValues = new TreeMap<>();
Review comment:
Would be nice to add a comment on why TreeMap (ordering) is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
