mayankshriv commented on a change in pull request #4387: Adding Calcite SQL
Parser and make another entry point to query Pinot
URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r301727582
##########
File path: pinot-common/pom.xml
##########
@@ -96,6 +96,10 @@
<groupId>org.antlr</groupId>
<artifactId>antlr4-runtime</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.calcite</groupId>
+ <artifactId>calcite-core</artifactId>
Review comment:
So are we bringing in a lot more (in calcite-core) than we need? Probably we
don't have an option, but in case we do, consider just getting the minimal
artifact available that we need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
