mayankshriv commented on a change in pull request #4387: Adding Calcite SQL
Parser and make another entry point to query Pinot
URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r300515438
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -338,6 +337,13 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
return brokerResponse;
}
+ private PinotQueryRequest getPinotQueryRequest(JsonNode request) {
+ if (request.has(SQL)) {
Review comment:
Would be good to assert that only one of SQL|PQL is specified in the request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
