mayankshriv commented on a change in pull request #4535: Implement DISTINCT
clause
URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r319191141
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunction.java
##########
@@ -119,4 +120,6 @@ IntermediateResult merge(@Nonnull IntermediateResult
intermediateResult1,
*/
@Nonnull
FinalResult extractFinalResult(@Nonnull IntermediateResult
intermediateResult);
+
+ void setRecordLimit(int recordLimit, Limits.LimitLevel level);
Review comment:
But it does not apply to any other aggregation function. One option (not
clean but better than this one) is to have the limit on the result holder.
Another option is to have a DistinctAggregationExecutor (might be better than
the other two).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
